Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#9025] fix keycard pairings persistence #9052

Merged
merged 1 commit into from
Oct 8, 2019
Merged

[#9025] fix keycard pairings persistence #9052

merged 1 commit into from
Oct 8, 2019

Conversation

dmitryn
Copy link
Contributor

@dmitryn dmitryn commented Sep 26, 2019 •
edited by StatusWrike
Loading

fixes #9025

Summary

  • Update pairings data in app-db after successful pair
  • Fix pairings retrieval

status: ready

@dmitryn dmitryn requested a review from a team as a code owner September 26, 2019 13:37
@dmitryn dmitryn self-assigned this Sep 26, 2019
@auto-assign auto-assign bot removed the request for review from a team September 26, 2019 13:37
@status-github-bot
Copy link

status-github-bot bot commented Sep 26, 2019 •
edited by dmitryn
Loading

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-im-auto
Copy link
Member

status-im-auto commented Sep 26, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (36)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a3211a9 #1 2019-09-26 13:47:54 ~10 min ios 📦ipa 📲
✔️ a3211a9 #1 2019-09-26 13:50:08 ~12 min macos 📦dmg
✔️ a3211a9 #1 2019-09-26 13:50:38 ~13 min android 📦apk 📲
✔️ a3211a9 #1 2019-09-26 13:50:41 ~13 min android-e2e 📦apk 📲
✔️ a3211a9 #1 2019-09-26 13:57:38 ~20 min linux 📦App
✔️ a3211a9 #1 2019-09-26 13:58:55 ~21 min windows 📦exe
✔️ 0e50508 #2 2019-09-27 09:35:11 ~8 min ios 📦ipa 📲
✔️ 0e50508 #2 2019-09-27 09:38:07 ~11 min macos 📦dmg
✔️ 0e50508 #2 2019-09-27 09:39:58 ~13 min android 📦apk 📲
✔️ 0e50508 #2 2019-09-27 09:39:58 ~13 min android-e2e 📦apk 📲
✔️ 0e50508 #2 2019-09-27 09:44:45 ~18 min linux 📦App
✔️ 0e50508 #2 2019-09-27 09:45:25 ~18 min windows 📦exe
✔️ 1c926ba #6 2019-09-27 10:46:26 ~8 min ios 📦ipa 📲
✔️ 1c926ba #5 2019-09-27 10:49:42 ~11 min macos 📦dmg
✔️ 1c926ba #7 2019-09-27 10:51:15 ~13 min android 📦apk 📲
✔️ 1c926ba #5 2019-09-27 10:52:01 ~13 min linux 📦App
✔️ 1c926ba #7 2019-09-27 10:54:54 ~16 min android-e2e 📦apk 📲
✔️ 1c926ba #5 2019-09-27 10:56:40 ~18 min windows 📦exe
✔️ 571dffc #7 2019-09-28 13:58:49 ~9 min ios 📦ipa 📲
✔️ 571dffc #6 2019-09-28 14:02:21 ~13 min macos 📦dmg
✔️ 571dffc #6 2019-09-28 14:03:10 ~14 min linux 📦App
✔️ 571dffc #6 2019-09-28 14:05:16 ~16 min windows 📦exe
✔️ 571dffc #8 2019-09-28 14:07:16 ~18 min android-e2e 📦apk 📲
✔️ 571dffc #8 2019-09-28 14:07:23 ~18 min android 📦apk 📲
❌ b5c2c08 #7 2019-10-01 16:55:23 ~3 min macos 📄log
❌ b5c2c08 #7 2019-10-01 16:56:01 ~3 min linux 📄log
❌ b5c2c08 #7 2019-10-01 16:56:04 ~3 min windows 📄log
✔️ b5c2c08 #8 2019-10-01 17:01:20 ~9 min ios 📦ipa 📲
❌ b5c2c08 #9 2019-10-01 17:07:25 ~15 min android 📄log
✔️ b5c2c08 #9 2019-10-01 17:08:30 ~16 min android-e2e 📦apk 📲
✔️ 5cf59de #9 2019-10-07 14:30:01 ~11 min ios 📦ipa 📲
✔️ 5cf59de #8 2019-10-07 14:32:24 ~13 min macos 📦dmg
✔️ 5cf59de #10 2019-10-07 14:32:49 ~14 min android 📦apk 📲
✔️ 5cf59de #10 2019-10-07 14:35:13 ~16 min android-e2e 📦apk 📲
✔️ 5cf59de #8 2019-10-07 14:35:49 ~17 min windows 📦exe
✔️ 5cf59de #8 2019-10-07 14:36:18 ~17 min linux 📦App
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c1c195a #11 2019-10-08 08:54:12 ~8 min ios 📦ipa 📲
✔️ c1c195a #12 2019-10-08 08:58:32 ~12 min android-e2e 📦apk 📲
✔️ c1c195a #12 2019-10-08 08:58:34 ~12 min android 📦apk 📲
✔️ 7252ae5 #9 2019-10-08 08:54:49 ~12 min macos 📦dmg
✔️ 7252ae5 #9 2019-10-08 08:57:51 ~15 min linux 📦App
✔️ 7252ae5 #9 2019-10-08 08:59:02 ~16 min windows 📦exe

@yenda
Copy link
Contributor

yenda commented Sep 28, 2019

lgtm squash and rebase before we test it please

@weekly-digest weekly-digest bot mentioned this pull request Sep 29, 2019
Closed
@weekly-digest weekly-digest bot mentioned this pull request Oct 6, 2019
Closed
@dmitryn dmitryn force-pushed the bug/9025-persist-pairings branch 2 times, most recently from 5cf59de to 7252ae5 Compare October 8, 2019 08:41
@dmitryn
[#9025] fix keycard pairings persistence
c1c195a 
Signed-off-by: Dmitry Novotochinov <dmitry.novot@gmail.com>
@dmitryn dmitryn merged commit c1c195a into develop Oct 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the bug/9025-persist-pairings branch October 8, 2019 08:45
@weekly-digest weekly-digest bot mentioned this pull request Oct 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenda yenda yenda left review comments

@flexsurfer flexsurfer flexsurfer approved these changes

@vitvly vitvly Awaiting requested review from vitvly

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't proceed with creating account if cancel process on "Confirm seed phrase"
4 participants
@dmitryn @status-im-auto @yenda @flexsurfer